Re: [hackers] [surf][PATCH] Don't call setstyle with an empty path

From: Antonio Quartulli <>
Date: Thu, 5 May 2022 09:11:08 +0200

On 05/05/2022 05:38, Nick Hanley wrote:
> On Wed, May 04, 2022 at 09:49:33AM +0200, Antonio Quartulli wrote:
>> On 04/05/2022 00:18, Nick Hanley wrote:
>>> On Tue, May 03, 2022 at 02:45:05PM -0400, wrote:
>>>> Just wondering - why not just do
>>>> if (*getstyle(geturi(c)))
>>>> setstyle(c, file);
>>> We need to pass the file path returned by getstyle to setstyle.
>> An alternative would be to keep the original nested invocation and add a
>> NULL check inside setstyle(). This would avoid adding an extra variable
>> 'file'.
> Is there a reason to avoid declaring a variable?

Well, the variable was not there, so the question is: is there a reason
to add it? :-D
IMHO the code is easier without it (as the variable is not used anywhere

Anyway, this is really just my opinion (it was the first time I wrote to
this mailing list), so I am not sure how important it is :)


Antonio Quartulli
Received on Thu May 05 2022 - 09:11:08 CEST

This archive was generated by hypermail 2.3.0 : Thu May 05 2022 - 09:12:39 CEST